- Download Diff

Summary:

10066 loader: Add isoboot(5) for booting BIOS systems from HDDs containing ISO images.

Review Request #1324 — Created Dec. 14, 2018 and submitted Jan. 8, 2019, 12:28 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	10066
Depends On:
Commit:	5534e32...
Reviewers
Groups:	general
People:

Description

FreeBSD update: https://svnweb.freebsd.org/base?view=revision&revision=332084

This is part of a project for adding the ability to create hybrid CD/USB boot
images. In the BIOS case when booting from something that isn't a CD we need
some extra boot code to actually find our next stage (loader) within an
ISO9660 filesystem. This code will reside in a GPT partition (similar to
gptboot(8) from which it is derived) and looks for /boot/loader in an
ISO9660 filesystem on the image.

Testing Done

Created and published the iso (http://148.52.235.80.sta.estpak.ee)

Issues

0
0
8
1
All Issues: 9

Description	From	Last Updated
I guess it's mainly to follow upstream, but it's weird that this lives in libstand, when in fact it doesn't ...	jlevon	Jan. 4, 2019, 11:23 a.m.
Should be GNUC_ROOT	jlevon	Jan. 3, 2019, 8:38 p.m.
Identation is a bit random in this Makefile: remove all the tabs/spaces so they're consistent?	jlevon	Jan. 4, 2019, 11:30 a.m.
We have to hard-code this?	jlevon	Jan. 4, 2019, 11:34 a.m.
unused?	jlevon	Jan. 4, 2019, 11:26 a.m.
Dead comment?	jlevon	Jan. 3, 2019, 8:38 p.m.
Are we planning to deliver a tool, or documentation, on exactly how to construct such USB disks in the future? ...	jlevon	Jan. 4, 2019, 11:16 a.m.
freebsd specifics?	jlevon	Jan. 3, 2019, 8:51 p.m.
ditto	jlevon	Jan. 3, 2019, 8:51 p.m.

Testing Done:

Created and published the iso (http://148.52.235.80.sta.estpak.ee)

I insecure downloaded all your files because the OpenIndiana_Text_X86.usb from the gz failed the SHA512. It is not the same file as the downloaded OpenIndiana_Text_X86.usb image.
I am using Debian 4.18.20:
$ gunzip -k OpenIndiana_Text_X86.usb.gz
$ openssl dgst -sha512 OpenIndiana_Text_X86.usb

SHA512(OpenIndiana_Text_X86.usb)= a4f3588a5cd77dc30bdf854c2ff8155b1360a7c69263710845e27e983ff11ec3e255f299bc07a7fd72f8bde2d7884fd03bfa31a2b2e72c9dd93e5250156aa8a2

$ gunzip -t OpenIndiana_Text_X86.usb
$ gunzip -l OpenIndiana_Text_X86.usb
compressed uncompressed ratio uncompressed_name
687696721 882135552 22.0% OpenIndiana_Text_X86.usb

tsoome Dec. 15, 2018, 7:11 a.m.

oops, yes, the gz varian is older, I'll fix it:)

tsoome Dec. 15, 2018, 7:15 a.m.
```
fixed.
```

usr/src/boot/lib/libstand/cd9660read.c (Diff revision 1)

Show all issues

I guess it's mainly to follow upstream, but it's weird that this lives in libstand, when in fact it doesn't use the libstand stuff like struct open_file etc. It's a special for isoboot only and should really be part of that dir - especially as the .c file is directly included!
So, if we want to leave this here, I think it'd be useful to add a comment explaining why it's here, its relationship to cd9660.c, and who actually uses it.

usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1)
Show all issues
```
Should be GNUC_ROOT
```

usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1)

Show all issues

Identation is a bit random in this Makefile: remove all the tabs/spaces so they're consistent?

usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1)

Show all issues

We have to hard-code this?

tsoome Jan. 4, 2019, 11:34 a.m.

It is a bit complicated. The orifinal FreeBSD makefile is using the VAR =? value construct (set unless it is already set), I left in the plain assign constructs just for the case we can figure something out.

usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1)
Show all issues
```
unused?
```
usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1)
Show all issues
```
Dead comment?
```

usr/src/man/man5/isoboot.5 (Diff revision 1)

Show all issues

Are we planning to deliver a tool, or documentation, on exactly how to construct such USB disks in the future? Right now it seems pretty obscure.

tsoome Jan. 3, 2019, 8:56 p.m.

I already have update waiting for distribution constructor, but the additional docs would be good indeed. The basic idea is that we need to fit in first 32k both partition table and isoboot binary, so the DC script does create MBR partition table with x86 boot partition and second partition for hsfs. Then we can use labeled lofi and installboot.

usr/src/man/man5/isoboot.5 (Diff revision 1)
Show all issues
```
freebsd specifics?
```
usr/src/man/man5/isoboot.5 (Diff revision 1)
Show all issues
```
ditto
```

Commit:

-	3fa78a1025357fa926c39195f16868971102ff52
+	ec9ffd07b6666486f25ec32de90b2137b5a4206a

Diff:

Revision 2 (+1114 -31)

Show changes

	usr/src/boot/lib/libstand/cd9660.c
	usr/src/boot/lib/libstand/cd9660read.c
	usr/src/boot/sys/boot/i386/Makefile
	usr/src/boot/sys/boot/i386/btx/Makefile
	usr/src/boot/sys/boot/i386/common/drv.c
	usr/src/boot/sys/boot/i386/isoboot/Makefile
	usr/src/boot/sys/boot/i386/isoboot/isoboot.c
	usr/src/man/man5/Makefile
	2 more

Commit:

-	ec9ffd07b6666486f25ec32de90b2137b5a4206a
+	be8f591c90d64f2cdf7ae584cd9f34f340d0ac84

Diff:

Revision 3 (+1112 -31)

Show changes

	usr/src/boot/lib/libstand/cd9660.c
	usr/src/boot/sys/boot/i386/Makefile
	usr/src/boot/sys/boot/i386/btx/Makefile
	usr/src/boot/sys/boot/i386/common/drv.c
	usr/src/boot/sys/boot/i386/isoboot/Makefile
	usr/src/boot/sys/boot/i386/isoboot/cd9660read.c
	usr/src/boot/sys/boot/i386/isoboot/isoboot.c
	usr/src/man/man5/Makefile
	2 more

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Change Summary:

rebase on 10028

Commit:

-	be8f591c90d64f2cdf7ae584cd9f34f340d0ac84
+	1fbdfe13d41cbb5f205eb9f115bcbe0ed0ef088e

Diff:

Revision 4 (+1112 -31)

Show changes

	usr/src/boot/lib/libstand/cd9660.c
	usr/src/boot/sys/boot/i386/Makefile
	usr/src/boot/sys/boot/i386/btx/Makefile
	usr/src/boot/sys/boot/i386/common/drv.c
	usr/src/boot/sys/boot/i386/isoboot/Makefile
	usr/src/boot/sys/boot/i386/isoboot/cd9660read.c
	usr/src/boot/sys/boot/i386/isoboot/isoboot.c
	usr/src/man/man5/Makefile
	2 more

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Change Summary:

../common/drv.c:31: warning: no previous prototype for 'drvsize'
../common/drv.c:79: warning: no previous prototype for 'drvwrite'

Commit:

-	1fbdfe13d41cbb5f205eb9f115bcbe0ed0ef088e
+	4b56602a8da77319adf204b3ee6e886c404249ec

Diff:

Revision 5 (+1112 -33)

Show changes

	usr/src/boot/lib/libstand/cd9660.c
	usr/src/boot/sys/boot/i386/Makefile
	usr/src/boot/sys/boot/i386/btx/Makefile
	usr/src/boot/sys/boot/i386/common/drv.h
	usr/src/boot/sys/boot/i386/common/drv.c
	usr/src/boot/sys/boot/i386/isoboot/Makefile
	usr/src/boot/sys/boot/i386/isoboot/cd9660read.c
	usr/src/boot/sys/boot/i386/isoboot/isoboot.c
	3 more

Ship it!

```
Ship It!
```

Change Summary:

install needs proper filemode.

Commit:

-	4b56602a8da77319adf204b3ee6e886c404249ec
+	5534e32838d98400574934c463a189325c366b95

Diff:

Revision 6 (+1113 -33)

Show changes

	usr/src/boot/lib/libstand/cd9660.c
	usr/src/boot/sys/boot/i386/Makefile
	usr/src/boot/sys/boot/i386/btx/Makefile
	usr/src/boot/sys/boot/i386/common/drv.h
	usr/src/boot/sys/boot/i386/common/drv.c
	usr/src/boot/sys/boot/i386/isoboot/Makefile
	usr/src/boot/sys/boot/i386/isoboot/cd9660read.c
	usr/src/boot/sys/boot/i386/isoboot/isoboot.c
	3 more

You have a pending review.

Review Board 3.0.18

10066 loader: Add isoboot(5) for booting BIOS systems from HDDs containing ISO images.

Testing Done:

Commit:

Diff:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)