10066 loader: Add isoboot(5) for booting BIOS systems from HDDs containing ISO images.
Review Request #1324 - Created Dec. 14, 2018 and submitted
| Information | |
|---|---|
| Toomas Soome | |
| illumos-gate | |
| 10066 | |
| 5534e32... | |
| Reviewers | |
| general | |
FreeBSD update: https://svnweb.freebsd.org/base?view=revision&revision=332084 This is part of a project for adding the ability to create hybrid CD/USB boot images. In the BIOS case when booting from something that isn't a CD we need some extra boot code to actually find our next stage (loader) within an ISO9660 filesystem. This code will reside in a GPT partition (similar to gptboot(8) from which it is derived) and looks for /boot/loader in an ISO9660 filesystem on the image.
Created and published the iso (http://148.52.235.80.sta.estpak.ee)
John Levon
Testing Done: |
|
|---|
I insecure downloaded all your files because the OpenIndiana_Text_X86.usb from the gz failed the SHA512. It is not the same file as the downloaded OpenIndiana_Text_X86.usb image.
I am using Debian 4.18.20:
$ gunzip -k OpenIndiana_Text_X86.usb.gz
$ openssl dgst -sha512 OpenIndiana_Text_X86.usbSHA512(OpenIndiana_Text_X86.usb)= a4f3588a5cd77dc30bdf854c2ff8155b1360a7c69263710845e27e983ff11ec3e255f299bc07a7fd72f8bde2d7884fd03bfa31a2b2e72c9dd93e5250156aa8a2
$ gunzip -t OpenIndiana_Text_X86.usb
$ gunzip -l OpenIndiana_Text_X86.usb
compressed uncompressed ratio uncompressed_name
687696721 882135552 22.0% OpenIndiana_Text_X86.usb
-
usr/src/boot/lib/libstand/cd9660read.c (Diff revision 1) -
I guess it's mainly to follow upstream, but it's weird that this lives in libstand, when in fact it doesn't use the libstand stuff like struct open_file etc. It's a special for isoboot only and should really be part of that dir - especially as the .c file is directly included!
So, if we want to leave this here, I think it'd be useful to add a comment explaining why it's here, its relationship to cd9660.c, and who actually uses it.
-
usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1) -
Should be GNUC_ROOT
-
usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1) -
Identation is a bit random in this Makefile: remove all the tabs/spaces so they're consistent?
-
usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1) -
We have to hard-code this?
-
usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1) -
unused?
-
usr/src/boot/sys/boot/i386/isoboot/Makefile (Diff revision 1) -
Dead comment?
-
usr/src/man/man5/isoboot.5 (Diff revision 1) -
Are we planning to deliver a tool, or documentation, on exactly how to construct such USB disks in the future? Right now it seems pretty obscure.
-
usr/src/man/man5/isoboot.5 (Diff revision 1) -
freebsd specifics?
-
usr/src/man/man5/isoboot.5 (Diff revision 1) -
ditto
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+1114 -31) |
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+1112 -31) |
Ship It!
Ship It!
Change Summary:
rebase on 10028
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+1112 -31) |
Ship It!
Ship It!
Change Summary:
../common/drv.c:31: warning: no previous prototype for 'drvsize'
../common/drv.c:79: warning: no previous prototype for 'drvwrite'
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+1112 -33) |
Ship It!
Change Summary:
install needs proper filemode.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+1113 -33) |