10064 loader: zfs reader should not probe partitionless disks
Review Request #1322 - Created Dec. 14, 2018 and submitted
| Information | |
|---|---|
| Toomas Soome | |
| illumos-gate | |
| 10064 | |
| c162a73... | |
| Reviewers | |
| general | |
10064 loader: zfs reader should not probe partitionless disks
The fix was confirmed by original reporter.
Andrew Stormont
-
usr/src/boot/sys/boot/zfs/zfs.c (Diff revision 1) -
I think you meant "hang when accessing past the end".
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+6 -5) |
Ship It!
Ship It!
Review request changed
Change Summary:
The UEFI implementation does only call zfs_probe_dev() with partitions, so we need to check for whole disk in zfs_probe_dev.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+20 -6) |
OK I'm not versed in the UEFI aspect, but I see how it's a more conservative patch in deciding not to probe. LGTM.
Review request changed
Change Summary:
version update
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+20 -6) |