10056 9894 broke PYTHON_VERSION

Review Request #1318 — Created Dec. 10, 2018 and submitted

Information
citrus
illumos-gate
master
10056
04a04ff...
Reviewers
general
andy_js 
10056 9894 broke PYTHON_VERSION
Built with and without PYTHON_VERSION set in .env

wsdiff against gate build shows no relevant differences.
citrus
danmcd
danmcd 
  1. Why "PYSHEBANG"? Did you just need a variable name different from PYTHON's reserved set?
    1. Yes, exactly that (better name suggestions accepted).
      

      When installing python3 scripts to proto, the shebang needs changing to python 3 and that originally meant overriding PYTHON in the python3 makefile. However, if somebody has set PYTHON in the environment, then overriding it does not work.
    2. Name is okay.  An explanatory one-line comment above it would be appreciated.
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




citrus




   

   

  

 



 















 





 

  

   




danmcd




   

   







  

 



 

  


   

   

    
 
danmcd


    
   


  

  

  



    




  1. 
 
    
  
    
   
    I'd have settled for one-line, but yes, this'll do nicely.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I could not come up with anything pithy enough :)
      
Thanks.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




tsoome




   

   







  

 



 

  


   

   

    
 
tsoome


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




citrus




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...