10054 loader: move 16KB BSS buffer from pxe to bio and use it with biosdisk

Review Request #1317 — Created Dec. 9, 2018 and submitted

tsoome
illumos-gate
10054
a83cb48...
general
10054 loader: move 16KB BSS buffer from pxe to bio and use it with biosdisk

This code is used in loader branch.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
igork
  1. Ship It!
  2. 
      
rejohnst
  1. WRT to bio_alloc() and bio_free(), there seems to be an implicit requirement that when one does multiple simultaneous allocations, they need to be freed in the reverse order (i.e. last allocated, first freed). I would add a comment to bio.c stating this requirement. Otherwise, the changes look fine.

    1. Yes there is. Eventually something better is needed (we already have one allocator for heap, second for module placement, for zfs reader, now for BIOS calls) - clearly we need to handle different memory zones and consumers and this does smell quite familiar, doesn't it:)

  2. 
      
tsoome
tsoome
domag02
  1. C-style issues.
  2. Please, remove one from the leading whitespaces.
  3. Please, remove the hyphen.
  4. Empty comment line, not needed.
  5. Space followed by tab.
  6. Space followed by tab (+ in the next 2 lines).
  7. 
      
tsoome
rejohnst
  1. Thanks for updating the comment. Looks good now.

  2. 
      
domag02
  1. Ship It!
  2. 
      
tsoome
tsoome
rejohnst
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...