10026 common/sha1: update for loader build

Review Request #1310 — Created Dec. 2, 2018 and submitted Dec. 10, 2018, 9:03 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	10026
Depends On:
Commit:	0236ba2...
Reviewers
Groups:	general
People:

Description

10026 common/sha1: update for loader build

Testing Done

Issues

0
0
2
2
All Issues: 4

Description	From	Last Updated
Is the standalone build always guaranteed to be at least c99?	rm	Dec. 3, 2018, 6:45 a.m.
I assume there's no good way to consolidate the standalone world with our own headers right now, is there?	rm	Dec. 3, 2018, 6:45 a.m.
Space followed by tab.	domag02	Dec. 4, 2018, 8:19 p.m.
Same.	domag02	Dec. 4, 2018, 8:19 p.m.

usr/src/common/crypto/sha1/sha1.c (Diff revision 1)

Show all issues

Is the standalone build always guaranteed to be at least c99?

tsoome Dec. 3, 2018, 6:44 a.m.

Always is such an strong criteria, but considering we have it c99 now, I do not see why we would want to downgrade. All of those structure initializers used etc etc...

usr/src/common/crypto/sha1/sha1.c (Diff revision 1)

Show all issues

I assume there's no good way to consolidate the standalone world with our own headers right now, is there?

tsoome Dec. 3, 2018, 6:44 a.m.

not right now, no. This will need the investigation and while it is definitely something we would like to have, the priority for such a task is not high at this time (for me).