10026 common/sha1: update for loader build

Review Request #1310 — Created Dec. 2, 2018 and submitted

tsoome
illumos-gate
10026
0236ba2...
general
10026 common/sha1: update for loader build


  • 0
  • 0
  • 2
  • 2
  • 4
Description From Last Updated
rm
  1. 
      
  2. usr/src/common/crypto/sha1/sha1.c (Diff revision 1)
     
     
     
     
     
    Is the standalone build always guaranteed to be at least c99?
    1. Always is such an strong criteria, but considering we have it c99 now, I do not see why we would want to downgrade. All of those structure initializers used etc etc...

  3. usr/src/common/crypto/sha1/sha1.c (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    I assume there's no good way to consolidate the standalone world with our own headers right now, is there?
    1. not right now, no. This will need the investigation and while it is definitely something we would like to have, the priority for such a task is not high at this time (for me).

  4. 
      
domag02
  1. Space-tab issues.
  2. usr/src/uts/common/sys/sha1.h (Diff revision 1)
     
     
    Space followed by tab.
  3. usr/src/uts/common/sys/sha1.h (Diff revision 1)
     
     
  4. 
      
tsoome
andy_js
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...