10025 qede: rename OFFSETOF to offsetof and remove local definitions

Reviews
Diff

- Download Diff

Information
Submitter:	Toomas Soome
Repository:	illumos-gate
Branch:
Bugs:	10025
Depends On:
Commit:	5c6faea...
Reviewers
Groups:	general
People:

Description

10025 qede: rename OFFSETOF to offsetof and remove local definitions

Testing Done

So in general, this seems OK. The one worry I have is that when we get updates from QLogic/Cavium is that because all of the 'ecore' code being shared between multiple operating systems is that this'll either get lost or harder to merge. But I'm not sure how much of a concern that should actually be. Since the odds are that'll be me, I'm OK trying to deal with that.

Robert Mustacchi Dec. 2, 2018, 8:06 a.m.

Maybe it's worth keeping their marco in bcam_osal.h, which is kind of like the Intel nic osdep.h and just definining it in terms of the sysmacros.h one instead?

Toomas Soome Dec. 2, 2018, 9:45 a.m.

I think it is worth to discuss with the author(s) - we definitely do not want (actually do not need) sysmacros.h - we have offsetof in sys/stddef.h; and we do get it with __containerof.

Toomas Soome Dec. 2, 2018, 11:01 p.m.

I totally forgot about the most important reason why we would like to touch such sources in first place - I think all current popular operating systems do have macros like offsetof and we really should avoid such private definitions:)

Ship it!

Ship It!

You have a pending review.

Review Board 2.5.16

Screenshots

Files

Status: Closed (submitted)