10015 nfs: macro expands to multiple statements

Review Request #1301 — Created Nov. 30, 2018 and submitted

tsoome
illumos-gate
10015
880711d...
general
../../common/fs/nfs/nfs4_client.c: In function 'nfs4_attr_cache':
../../common/fs/nfs/nfs4_client.c:517:28: error: macro expands to multiple statements [-Werror=multistatement-macros]
    PURGE_ATTRCACHE4_LOCKED(rp);
                            ^~
../../common/nfs/rnode4.h:444:2: note: in definition of macro 'PURGE_ATTRCACHE4_LOCKED'
  rp->r_time_attr_inval = gethrtime();   \
  ^~
../../common/fs/nfs/nfs4_client.c:516:3: note: some parts of macro expansion are not guarded by this 'if' clause
   if (!CACHE4_VALID(rp, vap->va_mtime, vap->va_size))
   ^~
cc1: all warnings being treated as errors

../../common/fs/nfs/nfs4_srv_deleg.c: In function 'rfs4freeargres':
../../common/nfs/nfs4.h:1046:2: error: macro expands to multiple statements [-Werror=multistatement-macros]
  kmem_free((str).utf8string_val, (str).utf8string_len); \
  ^~~~~~~~~
../../common/fs/nfs/nfs4_srv_deleg.c:743:3: note: in expansion of macro 'UTF8STRING_FREE'
   UTF8STRING_FREE(args->tag)
   ^~~~~~~~~~~~~~~
../../common/fs/nfs/nfs4_srv_deleg.c:742:2: note: some parts of macro expansion are not guarded by this 'if' clause
  if (args->tag.utf8string_len > 0)
  ^~
cc1: all warnings being treated as errors


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tsoome
igork
  1. 
      
  2. usr/src/uts/common/nfs/nfs4.h (Diff revision 2)
     
     

    why h4 instead of fh4 ?
    in comment - it is fid

    1. my sloppy fingers. thnx.

  3. 
      
seeemef@mac.com
  1. Ship It!
  2. 
      
tsoome
igork
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
marcel
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...