10007 loader: remove bcache marker code

Review Request #1295 — Created Nov. 25, 2018 and submitted

tsoome
illumos-gate
10007
0d7f375...
general
https://svnweb.freebsd.org/base?view=revision&revision=340857

Nuke out buffer overflow safety marker code, it duplicates similar code in
the malloc()/free() as well as having potential of softening the handling
in case error is detected down to a mere warning as compared to hard panic
in free().


gdamore
  1. Ship It!
  2. 
      
domag02
  1. Some whitespace nits, not really related with the current issue.
  2. usr/src/boot/sys/boot/common/bcache.c (Diff revision 1)
     
     
    Trailing whitespace.
  3. usr/src/boot/sys/boot/common/bcache.c (Diff revision 1)
     
     
    Trailing whitespace.
  4. usr/src/boot/sys/boot/common/bcache.c (Diff revision 1)
     
     
    Line contains only white-spaces.
  5. usr/src/boot/sys/boot/common/bcache.c (Diff revision 1)
     
     
    Line contains only white-spaces.
  6. 
      
tsoome
domag02
  1. 
      
  2. usr/src/boot/sys/boot/common/bcache.c (Diff revision 2)
     
     

    Signed print-unsigned value format mismaches, should be:

    printf("\ncache blocks: %u\n", bcache_total_nblks);
    printf("cache blocksz: %u\n", bcache_blksize);
    printf("cache readahead: %u\n", bcache_rablks);
    printf("unit cache blocks: %u\n",bcache_unit_nblks);
    printf("cached units: %u\n", bcache_units);
    printf("%u ops  %u bypasses  %u hits  %u misses\n", bcache_ops,
        bcache_bypasses, bcache_hits, bcache_misses);
    
    1. Those will go to separate issue, wont fix here.

    2. Ok.
  3. 
      
domag02
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...