10000 loader: stop using ../zfs/libzfs.h but instead use libzfs.h

Review Request #1293 — Created Nov. 21, 2018 and submitted

tsoome
illumos-gate
10000
1290
ba7c777...
general
FreeBSD update:
https://svnweb.freebsd.org/base?view=revision&revision=336085

Remove LOADER_ZFS_SUPPORT define - we only build with ZFS.


  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
alp
  1. Ship It!
  2. 
      
domag02
  1. 
      
  2. Unnecessary #endif /* USERBOOT_ZFS_SUPPORT */.

  3. 
      
domag02
  1. 
      
  2. It needs to be removed.
  3. It needs to be removed.
  4. It needs to be removed.
  5. It needs to be removed.
  6. 
      
tsoome
domag02
  1. "Trailing space" nits.
  2. Trailing space.
  3. Trailing space (here + next line).
  4. Trailing space.
  5. Trailing space.
  6. Trailing spaces.
  7. Trailing space.
  8. Trailing space (here + next line).
  9. 
      
tsoome
domag02
  1. Format string mismatches.
  2. Both bios_basemem and bios_extmem are unsigned variables.
    Shuld be:

    printf("BIOS %ukB/%ukB available memory\n", bios_basemem / 1024, bios_extmem / 1024);
    
  3. index is unsigned:

    panic("%s: can't enter dTLB slot %u data "
        "%#lx va %#lx", __func__, index, data,
        va);
    
  4. Same.

  5. 
      
domag02
  1. Ship It!
  2. 
      
alp
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...