6609 Placeholder for review of NULL pointer constant issues under uts/intel

Review Request #129 - Created Feb. 6, 2016 and updated

Information
Richard PALO
illumos-gate
5218, 6609
c48c4cb...
Reviewers
general

6609 NULL pointer constant issues under uts/intel

updated review since cstyle updates and rebase to a recent upstream (illumos-gate/master).

mail_msg and wsdiff (of cumulated build of il_6609, il_6610 and il_6611... respectively r/129, r/130 and r/131)
shows no significant differences (file attached).

NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .rodata difference detected.
NOTE: ELF .rodata difference detected.
NOTE: ELF .SUNW_dof difference detected.
NOTE: ELF .rodata difference detected.
NOTE: ELF .rodata difference detected.
NOTE: ELF .rodata difference detected.
NOTE: ELF .data difference detected.
NOTE: ELF .data difference detected.
NOTE: ELF .text difference detected.
NOTE: ELF .data difference detected.
NOTE: ELF .data difference detected.
NOTE: ASCII difference detected.

the SUNW_dof, .[ro]data and ASCII differences are related to the branch name and datetime stamps.
the only code difference (.text) is due to two source code lines being suppressed as detailed in
r/131 concerning usr/src/uts/i86pc/io/dr/dr.c

Although I had long run a version of the gate with these mods, I have not done so recently
waiting for a perl64 enabled patchset to push since I run basically on omnios-bloody.

Files


Toomas Soome
Richard PALO
Review request changed

Description:

~  

6609 Placeholder for review of NULL pointer constant issues under uts/intel

  ~

6609 NULL pointer constant issues under uts/intel

Testing Done:

  +

updated review since cstyle updates and rebase to a recent upstream (illumos-gate/master).

  +
  +

mail_msg and wsdiff (of cumulated build of il_6609, il_6610 and il_6611... respectively r/129, r/130 and r/131)

  + shows no significant differences (file attached).

  +
  +

NOTE: ELF .SUNW_dof difference detected.

  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .rodata difference detected.
  + NOTE: ELF .rodata difference detected.
  + NOTE: ELF .SUNW_dof difference detected.
  + NOTE: ELF .rodata difference detected.
  + NOTE: ELF .rodata difference detected.
  + NOTE: ELF .rodata difference detected.
  + NOTE: ELF .data difference detected.
  + NOTE: ELF .data difference detected.
  + NOTE: ELF .text difference detected.
  + NOTE: ELF .data difference detected.
  + NOTE: ELF .data difference detected.
  + NOTE: ASCII difference detected.

  +
  +

the SUNW_dof, .[ro]data and ASCII differences are related to the branch name and datetime stamps.

  + the only code difference (.text) is due to two source code lines being suppressed as detailed in
  + r/131 concerning usr/src/uts/i86pc/io/dr/dr.c

  +
  +

Although I had long run a version of the gate with these mods, I have not done so recently

  + waiting for a perl64 enabled patchset to push since I run basically on omnios-bloody.

Commit:

-ac875a312486f5b617fe120b5c44174af0c7d23f
+c48c4cb9dab4a4591c71db98177aa9e13000db5b

Diff:

Revision 2 (+49 -54)

Show changes

Added Files:

Josef Sipek
Ship It!
Ken Mays
Ship It!
Loading...