9955 loader: export boot pool and vdev GUID

Review Request #1270 — Created Nov. 4, 2018 and submitted

tsoome
illumos-gate
9955
1d87cdb...
general

9955 loader: export boot pool and vdev GUID



  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tsoome
tsoome
xenol
  1. Ship It!
  2. 
      
tsoome
tsoome
citrus
  1. Ship It!
  2. 
      
domag02
  1. 
      
  2. usr/src/boot/sys/boot/zfs/zfs.c (Diff revision 4)
     
     

    Wouldn't be better to use PRIu64 macro (from inttypes.h) instead of type casting?
    Example:

    ...
    snprintf(buf, sizeof (buf), "%"PRIu64, dev->pool_guid);
    setenv("zfs-bootpool", buf, 1);
    snprintf(buf, sizeof (buf), "%"PRIu64, spa->spa_boot_vdev->v_guid);
    setenv("zfs-bootvdev", buf, 1);
    snprintf(buf, sizeof (buf), "%s/%"PRIu64, spa->spa_name, objnum);
    ...
    
    1. *correction: from <sys/stdint.h>

    2. it actually is in inttypes, but much deeper (loader has its own private headers), still we can use just <inttypes.h>. will see after nightly anyhow.

  3. 
      
tsoome
domag02
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...