- Download Diff

Summary:

9940 _kobj_printf must use va_list

Review Request #1261 — Created Oct. 30, 2018 and submitted Oct. 31, 2018, 6:52 p.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	9940
Depends On:
Commit:	b005737...
Reviewers
Groups:	general
People:

Description

9940 _kobj_printf must use va_list

Testing Done

boot -B bootrd_debug=true

Ship it!

Looks good, thanks, but I think you mean "must use va_copy" in the bug

Change Summary:

add code for sparc. remove leftover va_copy.

Commit:

-	6266add07b8b3e5c07fea269bfdba7a8751cd9d2
+	88f9bbfff41eca02e4f48d5750891b3a5932b9db

Diff:

Revision 2 (+41 -18)

Show changes

	usr/src/uts/common/krtld/bootrd.c
	usr/src/uts/common/krtld/kobj.c
	usr/src/uts/common/krtld/kobj_subr.c
	usr/src/uts/common/sys/kobj_impl.h
	usr/src/uts/i86pc/os/fakebop.c
	usr/src/uts/intel/sys/bootconf.h
	usr/src/uts/sparc/os/bootops.c

Ship it!

```
Ship It!
```

Change Summary:

sparc version needs prototype.

Commit:

-	88f9bbfff41eca02e4f48d5750891b3a5932b9db
+	c2e8a9d016fc3815001094aafb7153c67d5df5de

Diff:

Revision 3 (+42 -18)

Show changes

	usr/src/uts/common/krtld/bootrd.c
	usr/src/uts/common/krtld/kobj.c
	usr/src/uts/common/krtld/kobj_subr.c
	usr/src/uts/common/sys/kobj_impl.h
	usr/src/uts/i86pc/os/fakebop.c
	usr/src/uts/intel/sys/bootconf.h
	usr/src/uts/sparc/os/bootops.c
	usr/src/uts/sun/sys/bootconf.h

Ship it!

```
Ship It!
```

Change Summary:

killing few whitespace nits

Commit:

-	c2e8a9d016fc3815001094aafb7153c67d5df5de
+	b005737f8f8177908b648a98b818918d19a4498e

Diff:

Revision 4 (+45 -21)

Show changes

	usr/src/uts/common/krtld/bootrd.c
	usr/src/uts/common/krtld/kobj.c
	usr/src/uts/common/krtld/kobj_subr.c
	usr/src/uts/common/sys/kobj_impl.h
	usr/src/uts/i86pc/os/fakebop.c
	usr/src/uts/intel/sys/bootconf.h
	usr/src/uts/sparc/os/bootops.c
	usr/src/uts/sun/sys/bootconf.h

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

9940 _kobj_printf must use va_list

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)