6579 installgrub efi_alloc_and_read() return value check is faulty

Review Request #125 — Created Jan. 26, 2016 and submitted

tsoome
illumos-gate
6579
7c84ede...
general
6579 installgrub efi_alloc_and_read() return value check is faulty

with unpatched installgrub:
root@test:~# installgrub -m /boot/grub/stage1 /boot/grub/stage2 /dev/rdsk/c0t1d0s0
cannot open/stat device /dev/rdsk/c0t1d0s2
Unable to gather device information for /dev/rdsk/c0t1d0s0

and patched version:

/tmp/installgrub -m /boot/grub/stage1 /boot/grub/stage2 /dev/rdsk/c0t1d0s0

Updating master boot sector destroys existing boot managers (if any).
continue (y/n)? y
WARNING: target device /dev/rdsk/c0t1d0s0 has a versioned stage2 that is going to be overwritten by a non versioned one
stage2 written to partition 0, 284 sectors starting at 1024 (abs 1280)
stage1 written to partition 0 sector 0 (abs 256)
stage1 written to master boot sector

tsoome
igork
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
hans
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...