9916 mdb ::dcmds and ::walkers could have filter options

Review Request #1249 — Created Oct. 23, 2018 and submitted

citrus
illumos-gate
master
9916
980339d...
general
9916 mdb ::dcmds and ::walkers could have filter options

> ::walkers avl
avl                      -
given any avl_tree_t *, forward walk all entries in tree

> ::walkers cyclic
cyclic_id_cache          - walk the cyclic_id_cache cache
cycomni                  - for an omnipresent cyclic, walk cyc_omni_cpu list
cyctrace                 - walk cyclic trace buffer

> ::walkers -n cyclic
cyclic_id_cache          - walk the cyclic_id_cache cache

> ::walkers -n cyc[ot]
cycomni                  - for an omnipresent cyclic, walk cyc_omni_cpu list
cyctrace                 - walk cyclic trace buffer

> ::help walkers

NAME
  walkers - list available walkers

SYNOPSIS
  ::walkers [[-n] pattern]

DESCRIPTION

  List all of the walkers that are currently available. If a
  pattern is provided then list only the walkers that
  match the provided regular expression.

  Options:
      -n       Match only the name, not the description.
      pattern  RE to match against name/description.

ATTRIBUTES

  Target: kvm
  Module: mdb
  Interface Stability: Evolving

Welcome to kmdb
kmdb: unable to determine terminal type: assuming `vt100'
Loaded modules: [ unix krtld genunix ]
[0]> ::dcmds cycl
cyccover                 - dump cyclic coverage information
cycid                    - dump a cyclic id
cyclic                   - developer information
cyctrace                 - dump cyclic trace buffer
[0]> ::walkers -n cyclic
[0]> ::walkers cyclic
cycomni                  - for an omnipresent cyclic, walk cyc_omni_cpu list
cyctrace                 - walk cyclic trace buffer
[0]> ::walkers -n cyc[ot]

[0]> ::help walkers

NAME
  walkers - list available walkers

SYNOPSIS
  ::walkers [[-n] pattern]

DESCRIPTION

  List all of the walkers that are currently available. If a
  pattern is provided then list only the walkers that
  contain the provided substring.

  Options:
      -n       Match only the name, not the description.
      pattern  Substring to match against name/description.

ATTRIBUTES

  Target: kmdb_kvm
  Module: kmdb
  Interface Stability: Evolving
igork
  1. Ship It!
  2. 
      
jlevon
  1. Looks fine, but did you test failing to compile the regular expression?

    1. > ::dcmds test[33
      mdb: brackets ([ ]) not balanced
      > ::dcmds test(
      mdb: parentheses not balanced
      
  2. 
      
citrus
Review request changed

Status: Closed (submitted)

Loading...