- Download Diff

Summary:

10071 genunix: loadable_syscall: cast between incompatible function types

Review Request #1244 — Created Oct. 16, 2018 and submitted Dec. 19, 2018, 8:53 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	10071
Depends On:
Commit:	2d08c57...
Reviewers
Groups:	general
People:

Description

../../intel/ia32/os/syscall.c: In function 'loadable_syscall':
../../intel/ia32/os/syscall.c:1208:14: error: cast between incompatible function types from 'int (*)()' to 'int64_t (*)()' {aka 'long int (*)()'} [-Werror=cast-function-type]
    sy_call = (int64_t (*)())callp->sy_call;
              ^
../../intel/ia32/os/syscall.c:1222:14: error: cast between incompatible function types from 'int (*)()' to 'int64_t (*)()' {aka 'long int (*)()'} [-Werror=cast-function-type]
    sy_call = (int64_t (*)())callp->sy_call;
              ^
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
6
0
All Issues: 6

Description	From	Last Updated
Space followed by tab.	domag02	Dec. 19, 2018, 5:54 a.m.
If one arm of an if-else statement contains braces, all arms should contain braces.	domag02	Dec. 19, 2018, 5:55 a.m.
If one arm of an if-else statement contains braces, all arms should contain braces.	domag02	Dec. 19, 2018, 5:56 a.m.
Space followed by tab.	domag02	Dec. 19, 2018, 5:55 a.m.
If one arm of an if-else statement contains braces, all arms should contain braces.	domag02	Dec. 19, 2018, 5:56 a.m.
If one arm of an if-else statement contains braces, all arms should contain braces.	domag02	Dec. 19, 2018, 5:55 a.m.

Ship it!

```
Ship It!
```

Summary:

-	genunix: loadable_syscall: cast between incompatible function types
+	10071 genunix: loadable_syscall: cast between incompatible function types

Bugs:

+	10071

Ship it!

```
Ship It!
```

```
C style issues.
```
usr/src/uts/intel/ia32/os/syscall.c (Diff revision 1)
Show all issues
```
Space followed by tab.
```

usr/src/uts/intel/ia32/os/syscall.c (Diff revision 1)

Show all issues

If one arm of an if-else statement contains braces, all arms should contain braces.

usr/src/uts/intel/ia32/os/syscall.c (Diff revision 1)

Show all issues

If one arm of an if-else statement contains braces, all arms should contain braces.

usr/src/uts/intel/ia32/os/syscall.c (Diff revision 1)
Show all issues
```
Space followed by tab.
```

usr/src/uts/intel/ia32/os/syscall.c (Diff revision 1)

Show all issues

If one arm of an if-else statement contains braces, all arms should contain braces.

usr/src/uts/intel/ia32/os/syscall.c (Diff revision 1)

Show all issues

If one arm of an if-else statement contains braces, all arms should contain braces.

Change Summary:

cstyle fixes

Commit:

-	52844112464d1f90b5ef87d4d1434484b202c777
+	2d08c570a8281a99c1c5be2cbf20c71f1afe16ee

Diff:

Revision 2 (+15 -14)

Show changes

usr/src/uts/intel/ia32/os/syscall.c

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

10071 genunix: loadable_syscall: cast between incompatible function types

Summary:

Bugs:

Change Summary:

Commit:

Diff:

Status: Closed (submitted)