9889 libbe reads defaults too often

Review Request #1232 — Created Oct. 12, 2018 and submitted

citrus
illumos-gate
master
9889
b248bab...
general
jimklimov
9889 libbe reads defaults too often

# truss -flea -t open beadm list 2>&1 | grep -c /etc/default/be
20991

LD_LIBRARY_PATH=. truss -flea -t open beadm list 2>&1 | grep -c /etc/default/be
# truss -flea -t open beadm list 2>&1 | grep -c /etc/default/be
6
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
citrus
igork
  1. Ship It!
  2. 
      
jimklimov
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
jclulow
  1. 
      
  2. usr/src/lib/libbe/common/be_list.c (Diff revision 1)
     
     

    It looks like we also use be_add_children_callback() here, with a blank list_callback_data_t (L363, above). Should we be calling be_get_defaults() in be_get_zone_be_list() as well?

    1. Nice catch, thanks. Fixed.

  3. 
      
citrus
hadfl
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
gdamore
  1. Ship It!
  2. 
      
jclulow
  1. Ship It!
  2. 
      
citrus
Review request changed

Status: Closed (submitted)

Loading...