9860 cpio_cleanup: $tarchive is already fully-qualified
Review Request #1223 — Created Oct. 1, 2018 and submitted
Information | |
---|---|
citrus | |
illumos-gate | |
master | |
9860 | |
bb00cf3... | |
Reviewers | |
general | |
9860 cpio_cleanup: $tarchive is already fully-qualified
With
set -x
at the start of the cpio_cleanup() function, before:omni# /boot/solaris/bin/create_ramdisk -R /a -f cpio Creating boot_archive for /a updating /a/platform/i86pc/amd64/boot_archive (CPIO) + [ -f //a//a/platform/i86pc/amd64/boot_archive.3245.new ] + [ -f //a//a/platform/i86pc/amd64/boot_archive.3245.new.cpio ] + [ -f //a//a/platform/i86pc/amd64/boot_archive.3245.new.hash ]After:
omni# /boot/solaris/bin/create_ramdisk -R /a -f cpio Creating boot_archive for /a updating /a/platform/i86pc/amd64/boot_archive (CPIO) + rm -f /a/platform/i86pc/amd64/boot_archive.762.new /a/platform/i86pc/amd64/boot_archive.762.new.cpio /a/platform/i86pc/amd64/boot_archive.762.new.hash
-
-
usr/src/cmd/boot/scripts/create_ramdisk.ksh (Diff revision 1) Do you even need to check the file's existence when using 'rm -f'?
Change Summary:
Remove unecessary -f tests.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+1 -3) |
Change Summary:
updated test notes.
Testing Done: |
|
---|