9860 cpio_cleanup: $tarchive is already fully-qualified

Review Request #1223 — Created Oct. 1, 2018 and submitted

citrus
illumos-gate
master
9860
bb00cf3...
general
9860 cpio_cleanup: $tarchive is already fully-qualified

With set -x at the start of the cpio_cleanup() function, before:

omni# /boot/solaris/bin/create_ramdisk -R /a -f cpio
Creating boot_archive for /a
updating /a/platform/i86pc/amd64/boot_archive (CPIO)
+ [ -f //a//a/platform/i86pc/amd64/boot_archive.3245.new ]
+ [ -f //a//a/platform/i86pc/amd64/boot_archive.3245.new.cpio ]
+ [ -f //a//a/platform/i86pc/amd64/boot_archive.3245.new.hash ]

After:

omni# /boot/solaris/bin/create_ramdisk -R /a -f cpio
Creating boot_archive for /a
updating /a/platform/i86pc/amd64/boot_archive (CPIO)
+ rm -f /a/platform/i86pc/amd64/boot_archive.762.new /a/platform/i86pc/amd64/boot_archive.762.new.cpio /a/platform/i86pc/amd64/boot_archive.762.new.hash
igork
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
andy_js
  1. 
      
  2. Do you even need to check the file's existence when using 'rm -f'?
  3. 
      
citrus
tsoome
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
citrus
citrus
Review request changed

Status: Closed (submitted)

Loading...