9724 qede: variable set but not used

Review Request #1158 — Created Aug. 11, 2018 and discarded

yuripv
illumos-gate
master
9724
general
9724 qede: variable set but not used

build only

tsoome
  1. Ship It!
    1. actually have question - it is not linted, right? (otherwise you would need some void casts:)

    2. Yes, it isn't. And I have actually looked into just disabling the warning in Makefile if there are testing questions, and let upstream sort it out.

  2. 
      
andy_js
  1. 
      
  2. Since this macro is basically a no-op, should we be initialising stats_type to something?

    1. Scratch that. I meant "stats", not "stats_type".

    2. That's likely a question to the driver authors, it's working as it is now and I'm not touching that.

  3. 
      
citrus
  1. Ship It!
  2. 
      
yuripv
Review request changed

Status: Discarded

Change Summary:

have no way to test, hopefully joyent will provide similar fix shortly

Loading...