Double-free in crypto tests on failure

Review Request #1127 — Created July 7, 2018 and submitted

jbk
illumos-gate
9644
general

If a crypto test fails, it will try to free some of the memory it allocated twice. This is easy to trigger by interposing libumem while running the crypto tests.

Running with libumem interposed + UMEM_DEBUG=default on the crypto tests will cause the AES CCM and GCM tests to crash due to the double free, when the should just exit with failure (due to pkcs11_softtoken.so not currently implementing them). With the fix, they fail due to lack of support as expected and do not crash when libumem is interposed.

tsoome
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
yuripv
  1. Ship It!
  2. 
      
andy_js
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
jbk
Review request changed

Status: Closed (submitted)

Loading...