711 smb_rename has its bitwise ops muddled

Review Request #1119 — Created June 26, 2018 and submitted

gwr
illumos-gate
711
general

711 smb_rename has its bitwise ops muddled

Some work by Aram that I forgot about.

This isn't actually exposed with Windows clients because those
check for existence of the destination before rename.
Nevertheless, it's a good fix.

Interestingly, both the current code and the fixed code work the same,
thanks to the accident of the flag it tests for being the only one.

smbtorture rename tests
Samba smbclient rename onto existing target.

yuripv
  1. Ship It!
  2. 
      
gwr
kmays
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
gwr
Review request changed

Status: Closed (submitted)

Loading...