9599 Buffer overflow in usr/src/lib/libsocket/inet/ruserpass.c

Review Request #1106 — Created June 15, 2018 and submitted

tsoome
illumos-gate
9599
30d7122...
general
9599 Buffer overflow in usr/src/lib/libsocket/inet/ruserpass.c


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
yuripv
  1. 
      
  2. usr/src/lib/libsocket/inet/ruserpass.c (Diff revision 1)
     
     

    May be you could change the size of buffer to PATH_MAX while here? BUFSIZ doesn't really have anything to do with path limitations.

  3. 
      
tsoome
yuripv
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
jbk
  1. 
      
  2. usr/src/lib/libsocket/inet/ruserpass.c (Diff revision 2)
     
     

    I suspect we might want to check the return value and error if the result is truncated.

  3. 
      
igork
  1. Ship It!
  2. 
      
tsoome
kmays
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
yuripv
  1. Ship It!
  2. 
      
vgusev
  1. Ship It!
  2. 
      
domag02
  1. 
      
  2. usr/src/lib/libsocket/inet/ruserpass.c (Diff revision 3)
     
     

    I think it's better: "Path to the HOME directory is too long: %s\n"

  3. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...