9589 ldterm_dosig() can send empty mblks downstream Reviewed by: Dominik Hassler <hadfl@omniosce.org>

Review Request #1101 — Created June 9, 2018 and submitted

citrus
illumos-gate
master
9589
25a9fb1...
general
9589 ldterm_dosig() can send empty mblks downstream Reviewed by: Dominik Hassler <hadfl@omniosce.org>

Tested with tmux linked against xpg6-values.o
Used dtrace to monitor putnext() to check that the null blocks are no longer sent.

igork
  1. Ship It!
  2. 
      
yuripv
  1. Makes sense.

    Though reading through ldterm_echo() was not as pleasant -- it surely could just return (0); at the end, and return (1); in previous else if block for easier reading.

    1. Indeed.. and in fact, if you look at the assembly code, the compiler turns the i++ statements into i = 1

      ldterm_echo+0x79:               movl   $0x1,%eax
      

      Thanks for taking the time to review.

  2. 
      
tsoome
  1. Ship It!
  2. 
      
citrus
Review request changed

Status: Closed (submitted)

Loading...