9625 krb5: logger.c was duplicated

Review Request #1089 — Created May 24, 2018 and updated July 10, 2018, 2:39 p.m.

Information
Owner:	andy_js
Repository:	illumos-gate
Branch:
Bugs:
Depends On:
Reviewers
Groups:	general
People:

Description

When src/lib/kadm5/logger.c was integrated it was copied to two locations:

usr/src/lib/krb5/kadm5/clnt/logger.c
usr/src/lib/krb5/kadm5/srv/logger.c

The two files have also been modified and are now out of sync.

Testing Done

Tested build only.

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
The default case should be to return back with the UFO string ("???"), meaning unknown errorno supplied. I think aborting ...	domag02	July 5, 2018, 8:57 p.m.

Status: Discarded

Status: Re-opened

Summary:

+	9625 krb5: logger.c was duplicated

Description:

	+	When src/lib/kadm5/logger.c was integrated it was copied to two locations:
	+
	+	usr/src/lib/krb5/kadm5/clnt/logger.c
	+	usr/src/lib/krb5/kadm5/srv/logger.c
	+
	+	The two files have also been modified and are now out of sync.

Testing Done:

Tested build only.

Diff:

Revision 1 (+20 -1180)

	usr/src/lib/krb5/kadm5/srv/logger.c
	usr/src/lib/krb5/kadm5/clnt/Makefile.com
	usr/src/lib/krb5/kadm5/clnt/logger.c
	usr/src/lib/krb5/kadm5/srv/Makefile.com

Ship it!

```
Ship It!
```

usr/src/lib/krb5/kadm5/logger.c (Diff revision 1)

Show all issues

The default case should be to return back with the UFO string ("???"), meaning unknown errorno supplied.
I think aborting without any notification is a bit too strict, and this modification changes the original behaviour of the code.