tmpfs mount options

Review Request #1 — Created March 16, 2015 and discarded

jclulow
illumos-gate
master
5720, 5721
general

5720 tmpfs should support gigabyte sizes
5721 tmpfs should support "mode" option



  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
I'm curious to know the reasoning to change from uint64_t to u_longlong_t. I came across recently the following: / * ... risto3 risto3
Flags is an 'int' not a pointer to something. please change the 2nd NULL to 0 risto3 risto3
gwr
  1. 
      
  2. 
      
risto3
  1. 
      
  2. usr/src/uts/common/fs/tmpfs/tmp_subr.c (Diff revision 1)
     
     

    I'm curious to know the reasoning to change from uint64_t to u_longlong_t.

    I came across recently the following:
    /
    * The types longlong_t and u_longlong_t exist for use with the
    * Sun-derived XDR routines involving these types, and their usage
    * in other contexts is discouraged. Further note that these types
    * may not be equivalent to "long long" and "unsigned long long",
    * they are only guaranteed to be signed and unsigned 64-bit types
    * respectively. Portable programs that need 64-bit types should use
    * the C99 types int64_t and uint64_t instead.
    /

  3. 
      
risto3
  1. 
      
  2. Flags is an 'int' not a pointer to something.
    please change the 2nd NULL to 0

  3. 
      
jclulow
Review request changed

Status: Discarded

Loading...